Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sun-setting the /store endpoint #1957

Closed
antonpirker opened this issue Mar 15, 2023 · 0 comments · Fixed by #2656
Closed

Sun-setting the /store endpoint #1957

antonpirker opened this issue Mar 15, 2023 · 0 comments · Fixed by #2656
Assignees

Comments

@antonpirker
Copy link
Member

antonpirker commented Mar 15, 2023

The /store endpoint to save events in Sentry is a legacy endpoint and should not be used anymore. Everything should be sent to the /envelope endpoint.

Here:
https://github.com/getsentry/sentry-python/blob/antonpirker/top-level-get-current-span-transaction/sentry_sdk/client.py#L443-L469

@antonpirker antonpirker added this to the Sentry SDK 2.0 milestone Mar 15, 2023
@smeubank smeubank changed the title Do not send anything to /store endpoint Get rid of /store endpoint Jun 13, 2023
@antonpirker antonpirker changed the title Get rid of /store endpoint Sun-setting the /store endpoint Jun 14, 2023
@szokeasaurusrex szokeasaurusrex self-assigned this Jan 15, 2024
@szokeasaurusrex szokeasaurusrex linked a pull request Jan 19, 2024 that will close this issue
@sentrivana sentrivana mentioned this issue Jan 22, 2024
szokeasaurusrex added a commit that referenced this issue Jan 29, 2024
## Summary

This change removes all usages of the deprecated `store` endpoint from the Python SDK. From now on, events that were previously sent to the `store` endpoint will now be sent as envelopes to the `envelope` endpoint. 


## Breaking API changes

  - `sentry_sdk.transport.Transport` is now an abstract base class, and therefore, it cannot be instantiated directly. Subclasses must implement the `capture_envelope` method.
  - `sentry_sdk.utils.Auth.store_api_url` has been removed.
  - `sentry_sdk.utils.Auth.get_api_url`'s now accepts a `sentry_sdk.consts.EndpointType` enum instead of a string as its only parameter. Supplying this parameter is currently unnecessary, since the parameter's default value is the only possible `sentry_sdk.consts.EndpointType` value.


## Backwards-compatible API changes
  - `sentry_sdk.transport.Transport.capture_event` has been deprecated. Please use `sentry_sdk.transport.Transport.capture_envelope`, instead.
  - Passing a function to `sentry_sdk.init`'s `transport` keyword argument has been deprecated. If you wish to provide a custom transport, please pass a `sentry_sdk.transport.Transport` instance or a subclass.


## Other changes
  - `sentry_sdk.transport.HttpTransport._send_event` has been removed, and uses of this method have been removed from the codebase, including from tests.
  - Cleaned up some transport-related test code

_________________________


* Remove store endpoint

* Fix linter error

* Add stacklevel to warn call

* Remove `store_api_url` test, update `get_api_url` test

* Fix mypy

* Correct import

* Use `Enum` instead of `StrEnum`

* Update `envelope.py`

* Remove `Envelope.events` calls

* Fix `capture_events_forksafe`

* Hopefully fix circular import

* Manually set TestTransport

* Fix circular import

* Revert "Fix circular import"

This reverts commit e681bdb.

* Revert "Hopefully fix circular import"

This reverts commit 7105849.

* Move EndpointType to top of file

* Fix AWS tests

* Remove TODO comment

* Undo ABC change
I will make a separate PR for this

* Update

* Rename envelope_item to envelope_items

* Remove unneeded import statement

* Updated migration guide

* Put back `has_tracing_enabled` check

* Remove test for replay context

* Update MIGRATION_GUIDE.md

* Auto-enable more integrations (#2671)

* Remove deprecated code (#2666)

* remove deprecated client options
* remove .install()
* remove new_span


Fixes GH-1957

---------

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants