Add Graphene GraphQL error integration #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture GraphQL errors when using Graphene and add more context to them (request data with syntax highlighting, if applicable).
Unlike the Ariadne integration in #2387 this integration doesn't add response data to the event. This is due to Graphene itself not providing any built-in tools for integrating with web frameworks (e.g. ready-made views), so this has to either be done by hand or by using an additional library. All in all, there is no way for us to hook into the request-response process with Graphene alone. If we want to capture responses, this should be done in our web framework integrations. In the spirit of small incremental changes this is not part of this PR.
Example event in Sentry: https://sentry-sdks.sentry.io/issues/4494299621/events/381fdf951b224f1db9a70cda3203f105/
Graphene is one of three integrations for #2257, split from #2381.