Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected sentry_trace_meta data in RQ task delay(...) call #2560

Closed
robhudson opened this issue Nov 29, 2023 · 3 comments
Closed

Unexpected sentry_trace_meta data in RQ task delay(...) call #2560

robhudson opened this issue Nov 29, 2023 · 3 comments

Comments

@robhudson
Copy link

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

PR change upgrading from older sentry-sdk version to newer (1.26.0 to 1.38.0) resulted in a failing test with the sentry_trace_meta data showing up in a delay(...) call which seems unexpected.

mozmeao/basket#1239

Expected Result

No sentry_trace_meta data in the delay call.

Actual Result

E           AssertionError: expected call not found.
E           Expected: delay('SUBSCRIBE', {'newsletters': ['slug'], 'email': 'dude@example.com', 'privacy': True, 'format': 'H', 'first_name': '', 'last_name': '', 'country': '', 'source_url': ''})
E           Actual: delay('SUBSCRIBE', {'newsletters': ['slug'], 'email': 'dude@example.com', 'privacy': True, 'format': 'H', 'first_name': '', 'last_name': '', 'country': '', 'source_url': '', 'sentry_trace_meta': '<meta name="sentry-trace" content="42e7d5aeba5f48138a2e2b7c12758f2b-b52eeeecb993a12e"><meta name="baggage" content="sentry-trace_id=42e7d5aeba5f48138a2e2b7c12758f2b,sentry-environment=production,sentry-release=latest">'})

Product Area

Unknown

Link

No response

DSN

No response

Version

No response

@getsantry
Copy link

getsantry bot commented Nov 29, 2023

Assigning to @getsentry/support for routing ⏲️

@JLuse JLuse transferred this issue from getsentry/sentry Dec 1, 2023
@antonpirker
Copy link
Member

Please give more details @robhudson
I do not know what tests you are running and what you are testing for and if the sentry_trace_meta showing up in you test ist a problem or you just need to update your test to work with new SDK version. I also do not know what delay(...).

If you want us to help you, you need to write a better Github issue

@robhudson
Copy link
Author

I did more testing and verified that sentry isn't actually adding args/kwargs to our RQ tasks via the delay(...) call, as the failed test seemed to suggest. It appears to be unittest specific. So I've disabled sentry in our unit tests. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants