Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentry-sdk #1239

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Update sentry-sdk #1239

merged 1 commit into from
Dec 5, 2023

Conversation

robhudson
Copy link
Contributor

Note: Without the test change, I got the test error:

E           AssertionError: expected call not found.
E           Expected: delay('SUBSCRIBE', {'newsletters': ['slug'], 'email': 'dude@example.com', 'privacy': True, 'format': 'H', 'first_name': '', 'last_name': '', 'country': '', 'source_url': ''})
E           Actual: delay('SUBSCRIBE', {'newsletters': ['slug'], 'email': 'dude@example.com', 'privacy': True, 'format': 'H', 'first_name': '', 'last_name': '', 'country': '', 'source_url': '', 'sentry_trace_meta': '<meta name="sentry-trace" content="42e7d5aeba5f48138a2e2b7c12758f2b-b52eeeecb993a12e"><meta name="baggage" content="sentry-trace_id=42e7d5aeba5f48138a2e2b7c12758f2b,sentry-environment=production,sentry-release=latest">'})

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac269c8) 86.81% compared to head (86611b5) 86.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1239   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          41       41           
  Lines        2458     2458           
=======================================
  Hits         2134     2134           
  Misses        324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robhudson
Copy link
Contributor Author

I confirmed that sentry is not adding extra kwargs to our RQ tasks as the test failure would suggest...

>>> zlib.decompress(conn.hget(b'rq:job:f87086a3-672d-480b-b202-0496129fc59b', 'data'))
b'["basket.news.tasks.upsert_user", null, ["SET", {"format": "H", "country": "us", "lang": "en", "newsletters": "mozilla-and-you", "optin": "Y", "source_url": "http://localhost:8000/newsletter/existing/", "token": "301deda0-8870-4bca-ab79-689326787e2b"}], {}]'

There is some tracing in the job's meta which I would expect given we have the RQ integration:

>>> conn.hget(b'rq:job:f87086a3-672d-480b-b202-0496129fc59b', 'meta')
b'{"task_name": "basket.news.tasks.upsert_user", "start_time": 1701802014.3174195, "_sentry_trace_headers": {"sentry-trace": "f032139249c74772a5221ce7e9f68990-a0d82775bb15a92a", "baggage": "sentry-trace_id=f032139249c74772a5221ce7e9f68990,sentry-environment=production,sentry-release=latest"}}'

I have removed sentry from our unit test runs in this commit.

Copy link
Contributor

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💂‍♀️

@robhudson robhudson merged commit 0de3bc1 into main Dec 5, 2023
3 checks passed
@robhudson robhudson deleted the bump-sentry branch December 5, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants