Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace propagation is broken under Celery 4.4 #824

Closed
untitaker opened this issue Sep 17, 2020 · 0 comments · Fixed by #825
Closed

Trace propagation is broken under Celery 4.4 #824

untitaker opened this issue Sep 17, 2020 · 0 comments · Fixed by #825
Assignees
@untitaker
Labels
Type: Bug Something isn't working

Comments

@untitaker
Copy link
Member

untitaker commented Sep 17, 2020 •
edited

We upgraded from Celery 4.1.1 to 4.4.7 on sentry.io and now we're missing trace headers. It's probably celery/celery#4875. Investigate what's happening and why tests didn't catch this.
@untitaker untitaker added the Type: Bug Something isn't working label Sep 17, 2020
@untitaker untitaker self-assigned this Sep 17, 2020
@untitaker untitaker mentioned this issue Sep 18, 2020
Merged
untitaker added a commit that referenced this issue Sep 21, 2020
@untitaker
fix(celery): Fix dropped transactions under Celery 4.2+ (#825)
633dba9 
* Work around celery/celery#4875 which causes us to lose transaction events. Fix #824 
* Rewrite celery testsuite to use redis backend and test transactions too. This is better because it works on more celery versions (memory backend is often broken). However, this still does not trigger the bug, so I guess for this to be properly tested we'd need to install rabbitmq into CI? No thanks
@untitaker untitaker mentioned this issue Sep 23, 2020
Merged
untitaker added a commit that referenced this issue Sep 23, 2020
@untitaker
fix: Second attempt at fixing trace propagation in Celery 4.2+ (#831)
4bf4859 
Follow-up to #824 #825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@untitaker untitaker

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(celery): Fix dropped transactions under Celery 4.2+ getsentry/sentry-python
1 participant
@untitaker