feat(profiling): Add support for profiles_sample_rate #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way profiling is enabled in the python sdk by allowing the end user to specify a `profiles_sample_rate` which is used to control the sampling of profiles. This sample rate is relative to the `traces_sample_rate` meaning the true sample rate of profiles is approximately equal to `traces_sample_rate * profiles_sample_rate`.
26 tasks
sl0thentr0py
approved these changes
Sep 14, 2022
Zylphrex
deleted the
txiao/feat/add-support-for-profiles-sample-rate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way profiling is enabled in the python sdk by allowing the end user to specify a
profiles_sample_ratewhich is used to control the sampling of profiles. This sample rate is relative to thetraces_sample_ratemeaning the true sample rate of profiles is approximately equal totraces_sample_rate * profiles_sample_rate.