Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relay extension from AWS layer #2068

Merged
merged 3 commits into from
May 10, 2023
Merged

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented May 3, 2023

we're reverting back to the older setup since the whole 'relay as AWS extension' experiment didn't really work out.

  • remove gh action that bundles relay
  • remove port override in DSN
  • zip in place as part of make build_aws_lambda_layer

part of getsentry/team-webplatform-meta#58

Makefile Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in "Conversation" tab.

* Add `loguru` integration

Actually, this is the solution in comments under #653 adapted to
codebase and tested as well.
#653 (comment)

I also changed `logging` integration to use methods instead of
functions in handlers, as in that way we can easily overwrite parts
that are different in `loguru` integration. It shouldn't be a problem,
as those methods are private and used only in that file.

---------

Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and the resulting layer zip looks similar enought to the old one. So LGTM.

we're reverting back to the older setup since the whole 'relay as AWS extension' experiment didn't really work out.
* revert port override in DSN
* remove gh action that bundles relay
* zip in place as part of `make build_aws_lambda_layer`

part of getsentry/team-webplatform-meta#58
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) May 9, 2023 12:51
@sl0thentr0py sl0thentr0py merged commit e0209db into master May 10, 2023
244 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/remove-relay-aws branch May 10, 2023 11:47
@bruceduhamel
Copy link

I came across this issue while investigating how to setup the aws lambda extension for some python lambdas I have integrated with sentry.

My original goal was to improve lambda performance when events are delivered to sentry.io.
I figured I would install the lambda extension via a lambda layer and configure my app to point to the relay.
I didn't find documentation for this approach, and this issue suggests that maybe isn't the way.

I found docs on how to setup a more point and click integration with lambda here: https://docs.sentry.io/product/integrations/cloud-monitoring/aws-lambda/#configure but these don't seem to have limited configuration support through a few environment variables, where I have specific config for the sentry python sdk and a few integrations that don't appear to be supported.

Is the lambda extension running relay no longer supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants