Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow (some) autocompletion for top-level API #2213

Merged
merged 16 commits into from
Jul 4, 2023
Merged

Allow (some) autocompletion for top-level API #2213

merged 16 commits into from
Jul 4, 2023

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 29, 2023 •
edited
Loading

  • Support autocompletion for the most commonly used args/kwargs of the top level API and remove some arg duplication. Couldn't get this done for everything and for all args/kwargs, but it should be an improvement compared to now. Step by step.
  • Also added Span and Transaction to the docs. (For some reason, autodocumenting the tracing.py module doesn't do anything so had to add the classes explicitly.)
  • Expanded some docstrings, too.

Fixes #2199
Fixes #2196

@sentrivana sentrivana mentioned this pull request Jun 29, 2023
Closed
@sentrivana sentrivana marked this pull request as ready for review June 29, 2023 11:19
@sentrivana sentrivana changed the title Allow autocompletion for top-level API Allow (some) autocompletion for top-level API Jun 29, 2023
@sentrivana sentrivana enabled auto-merge (squash) July 4, 2023 11:00
@sentrivana sentrivana merged commit 7719950 into master Jul 4, 2023
243 checks passed
@sentrivana sentrivana deleted the ivana/no-kwargs branch July 4, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Top-level API should list possible args/kwargs explicitly Improve API docs
2 participants
@sentrivana @antonpirker