Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Added log messages where lifecycle hooks could be #2355

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Sep 7, 2023

If we want to make lifecycle hooks a reality at some point, I guess we start with small steps.

I added some debug messages to places where lifecycle hooks could be. We can bike-shed about the names in this PR!

This already uncovered some places where our architecture needs some improvements to have a nice implementation.

This absolutely floods our debug log with messages, so maybe we remove some before we merge these.

@sentrivana
Copy link
Contributor

Nice! I think this is a good experiment. Just skimmed through and these make sense to me as hooks. (We can ofc still discuss trimming it down and bikeshed about naming. 😄)

This already uncovered some places where our architecture needs some improvements to have a nice implementation.

What places for example? 👀

@sl0thentr0py
Copy link
Member

fine in principle,

  • just make sure you don't log the whole event anywhere, this caused problems in the past
  • i would argue on the naming that you don't just call them as what is being done but what the hook will be
    • transaction_finish -> transaction.on_finish
    • scope_apply_to_event -> scope.before/after_apply
    • span_start -> span.before/after_start

@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
@antonpirker antonpirker added the Component: SDK Core Dealing with the core of the SDK label Jun 6, 2024
@antonpirker antonpirker added this to the SDK Core milestone Jun 7, 2024
@antonpirker antonpirker removed this from the SDK Core milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: SDK Core Dealing with the core of the SDK Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants