Update CONTRIBUTING.md #2411
Merged
Update CONTRIBUTING.md #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2023 11:07
cleptric
reviewed
Oct 4, 2023
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com> Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
cleptric
approved these changes
Oct 4, 2023
szokeasaurusrex
approved these changes
Oct 4, 2023
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we don't mention forking anywhere in our CONTRIBUTING.md, it says to just clone the repo directly, which is not really how it works.
Rendered file: https://github.com/getsentry/sentry-python/blob/54931541f6255c4e73bd8232e21b7c06bad7508f/CONTRIBUTING.md