Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pull request template #2549

Merged
merged 12 commits into from
Dec 6, 2023
Merged

Add a pull request template #2549

merged 12 commits into from
Dec 6, 2023

Conversation

sentrivana
Copy link
Contributor

Since we've changed our PR workflow with the addition of the Trigger: tests using secrets label, let's persist this info somewhere for both external contributors and folks maintaining the repo.

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as is. I added some suggestions for how we could improve the wording; please feel free to accept or reject these suggestions as you see fit

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
sentrivana and others added 2 commits December 4, 2023 16:14
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
@sentrivana
Copy link
Contributor Author

Thanks @szokeasaurusrex! Applied your suggestions.

sentrivana and others added 2 commits December 4, 2023 16:19
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
@sentrivana sentrivana enabled auto-merge (squash) December 6, 2023 13:09
auto-merge was automatically disabled December 6, 2023 13:13

Pull Request is not mergeable

@sentrivana sentrivana enabled auto-merge (squash) December 6, 2023 13:15
@sentrivana sentrivana merged commit 0eb3465 into master Dec 6, 2023
469 checks passed
@sentrivana sentrivana deleted the ivana/pull-request-template branch December 6, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants