Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Fix UnicodeDecodeError on Python 2 #2657

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 18, 2024

There were at least two things wrong with our strip_string implementation:

This PR addresses both issues.

Closes #2612
Closes #2634


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review January 19, 2024 15:21
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should work!

@sentrivana sentrivana merged commit e373e35 into master Jan 29, 2024
122 of 123 checks passed
@sentrivana sentrivana deleted the ivana/fix-unicodedecodeerror-py27 branch January 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strip_string trims by number of chars instead of bytes UnicodeDecodeError when using cp-1252 file enconding
2 participants