ref: Explicit reexport of types (backport to 1.x) #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Explicitly reexport types to make strict mypy setups happy
sentrivana
reviewed
Mar 27, 2024
| @@ -12,3 +12,5 @@ | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from sentry_sdk._types import Event, Hint # noqa: F401 | |||
|
|
|||
| __all__ = ["Event", "Hint"] | |||
There was a problem hiding this comment.
Is it ok that this is behind TYPE_CHECKING? Not too deep into the topic but #2909 seems to suggest it shouldn't be?
sentrivana
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly reexport types to make strict mypy setups happy. This backports #2866 to 1.x.
Fixes GH-2910