Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scope): New set_tags function #2978

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Apr 15, 2024

Scope.set_tags allows multiple tags to be set at the same time by passing the tags to update as a dictionary (or other Mapping type).

Closes GH-1344

@sentrivana
Copy link
Contributor

@szokeasaurusrex Please add the tests and the top-level API to this PR -- it all belongs together and should be reviewed together.

@szokeasaurusrex szokeasaurusrex marked this pull request as draft April 15, 2024 11:35
tests/test_scope.py Outdated Show resolved Hide resolved
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 15, 2024 12:02
@szokeasaurusrex
Copy link
Member Author

@szokeasaurusrex Please add the tests and the top-level API to this PR -- it all belongs together and should be reviewed together.

@sentrivana, done!

@szokeasaurusrex szokeasaurusrex linked an issue Apr 15, 2024 that may be closed by this pull request
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Please also update https://docs.sentry.io/platforms/python/enriching-events/tags/ and potentially other places in the docs where it makes sense.

tests/test_api.py Outdated Show resolved Hide resolved
tests/test_scope.py Outdated Show resolved Hide resolved
tests/test_scope.py Outdated Show resolved Hide resolved
sentry_sdk/scope.py Show resolved Hide resolved
szokeasaurusrex added a commit to getsentry/sentry-docs that referenced this pull request Apr 15, 2024
Add documentation for the [new `set_tags` function](getsentry/sentry-python#2978) in the Python SDK.

Closes GH-9703
szokeasaurusrex added a commit to getsentry/sentry-docs that referenced this pull request Apr 16, 2024
Add documentation for the [new `set_tags` function](getsentry/sentry-python#2978) in the Python SDK.

Closes GH-9703
Base automatically changed from sentry-sdk-2.0 to master April 25, 2024 09:13
szokeasaurusrex and others added 6 commits April 26, 2024 12:26
`Scope.set_tags` allows multiple tags to be set at the same time by passing the tags to update as a dictionary (or other `Mapping` type).

Closes GH-1344
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
@szokeasaurusrex szokeasaurusrex merged commit ab11fb7 into master Apr 26, 2024
110 of 111 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/set-tags branch April 26, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_tags missing from python SDK
2 participants