Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope): Clear last_event_id on scope clear #3124

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Jun 3, 2024

This PR includes a change that was split off from #3114.

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/clear-last-event-id branch from 2c9d73d to 3098df0 Compare June 3, 2024 14:05
@szokeasaurusrex szokeasaurusrex self-assigned this Jun 3, 2024
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/clear-last-event-id branch from 3098df0 to c08ff62 Compare June 5, 2024 14:12
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review June 5, 2024 14:15
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

szokeasaurusrex and others added 2 commits June 6, 2024 09:51
Co-authored-by: Adam Johnson <me@adamj.eu>
Add test to ensure that clearing the isolation scope clears the `last_event_id`.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/clear-last-event-id branch from 72ca529 to 7674bf2 Compare June 6, 2024 13:52
@szokeasaurusrex szokeasaurusrex merged commit 7674bf2 into master Jun 6, 2024
111 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/clear-last-event-id branch June 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants