Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update last_event_id in migration guide #3126

Merged

Conversation

szokeasaurusrex
Copy link
Member

Update the migration guide to mention that last_event_id has been reintroduced.

Fixes GH-3118

@sl0thentr0py
Copy link
Member

if we brought it back I'd just not mention it anymore to reduce confusion

@szokeasaurusrex
Copy link
Member Author

Fair enough @sl0thentr0py – my thought was what if someone tried to upgrade to 2.0.0, which does not have last_event_id – in that case, this mention could be helpful. But, it is probably unlikely that someone tries to do that, and if they do, I suppose they can just read the changelog

Since we reintroduced `last_event_id` in 2.2.0, we should remove it from the migration guide.

Fixes GH-3118
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/last_event_id-migration-guide branch from d099f5d to bb918fb Compare June 3, 2024 18:17
@szokeasaurusrex szokeasaurusrex merged commit bb918fb into master Jun 3, 2024
111 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/last_event_id-migration-guide branch June 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Migration Guide regarding removal of last_event_id()
2 participants