-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting auth.token from .env #1888
Comments
kinda related to #831 |
ideally, we'd patch https://github.com/getsentry/sentry-react-native/blob/master/sentry.gradle#L108-L124 to not add the args in case they don't have a value, so sentry-cli would be able to read the env. var.
would be a solution but sentry-cli already looks up into |
@marandaneto that sounds much better indeed, any plans on doing that in the near future? |
@fragilehm we didn't define priorities yet, but it should not be super hard, what's about submitting a PR? would you be interested? I can guide with reviews |
Has anyone made any progress on this or is there another way to use env variables over sentry.properties? |
In the current version of RN SDK https://github.com/getsentry/sentry-react-native/releases/tag/5.6.0 and bundled Sentry CLI https://github.com/getsentry/sentry-cli/releases/tag/2.18.1 this works. If auth token is present in |
So right now I have
sentry.properties
file withauth.token
filled in, in order to upload the source map. I understand that we can add this file to .gitignore not to expose the token to the remote repo. But we are usingappcenter
which also does build the release application so it needs to upload the sentry source map as well, but there is no option to get theauth.token
from the specific file which is not in the repo, but we can set the env variables. So I was wondering if we could get theauth.token
from .env instead or leave the default to get the variable from thesentry.properties
file but in case it is not configured there, get it from .env something like:"--auth-token", sentryProps.get("auth.token") ?: project.env.get("SENTRY_AUTH_TOKEN")
The text was updated successfully, but these errors were encountered: