React Native Error Handler doesn't wait for events to be flushed

[krystofwoldrich]

Description

Then unhandled JS error is thrown the global error handler creates an event from it.

This handler should wait until the current events in the transport queue are flushed, but because the handle is handled by RN as a synchronous function it doesn't wait.

Because it doesn't wait for events to be flushed, events with screenshots, view hierarchy, or larger attachments might not make it to be saved by the native SDK to be sent on the next start.

It doesn't seem to be an issue at the moment, but I wanted to make a note about it.

We could use something similar to https://github.com/a7ul/react-native-exception-handler to postpone the crash on native layers.

sentry-react-native/src/js/integrations/reactnativeerrorhandlers.ts

Lines 212 to 215 in d7401ac

	if (!__DEV__) {
	void client.flush(options.shutdownTimeout || 2000).then(() => {
	defaultHandler(error, isFatal);
	});