Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @sentry/svelte SDK #80

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 9, 2022

This PR adds the Sentry Svelte SDK (which we're going to release the first Alpha version of soon) to the release registry.

Full disclosure: This is my first time submitting a PR to the release registry so please feel free to tell me what I need to do additionally. Followed the Readme and what was done in #77 with the Remix SDK.

Ref: getsentry/sentry-javascript#5520 (JS SDK issue tracking the first release of the Svelte SDK)

{
"name": "Sentry Svelte SDK",
"canonical": "npm:@sentry/svelte",
"version": "7.9.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added version 7.9.0 which is the latest version of the JS SDKs. Should I bump this to the version that the Svelte SDK will be released with (which I suspect will be 7.10.0)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this should be the first version that the SDK is available with. Hence we should wait until that first release for us to add to the release registry.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, then let's wait for the release 👍

"version": "7.9.0",
"package_url": "https://npmjs.com/package/@sentry/svelte",
"repo_url": "https://github.com/getsentry/sentry-javascript",
"main_docs_url": "https://docs.sentry.io/platforms/javascript/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're currently not planning on having official docs for the first Alpha release of the Svelte SDK. I linked to the general Javascript (= Browser SDK) guide for the time being. The Svelte SDK right now is only a wrapper around the Browser SDK without much added stuff on top (that will follow later on). Is this fine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just put a link to where svelte will live in the future. The things that consume release registry (the docs and sentry onboarding flows) are not yet going to exist yet, so we can do this without any problems.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, then I'll change the link to the future Svelte guide. My concern was that this would already somewhere be shown in the UI and hence point to a link that doesn't (yet) exist.

@Lms24
Copy link
Member Author

Lms24 commented Aug 10, 2022

@mitsuhiko would you mind giving this a look and merge? We're ready to release. Thanks!

@mitsuhiko mitsuhiko merged commit e45fdfa into getsentry:master Aug 10, 2022
adinauer pushed a commit to adinauer/sentry-release-registry that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants