Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record redis command arguments in breadcrumbs and tracing spans. #1718

Closed
st0012 opened this issue Feb 10, 2022 · 1 comment · Fixed by #1726
Closed

Record redis command arguments in breadcrumbs and tracing spans. #1718

st0012 opened this issue Feb 10, 2022 · 1 comment · Fixed by #1726
Assignees
@st0012
Labels
enhancement sentry-ruby tracing
Projects
5.x
Milestone
5.2.0

Comments

@st0012
Copy link
Collaborator

st0012 commented Feb 10, 2022

Describe the idea

Record redis command arguments in breadcrumbs and tracing spans.
The value should only be recorded if send_default_pii == true

Why do you think it's beneficial to most of the users

It provides more information to help users debug.
@st0012 st0012 added this to the 5.2.0 milestone Feb 10, 2022
@st0012 st0012 added this to To do in 5.x via automation Feb 10, 2022
@st0012 st0012 mentioned this issue Feb 10, 2022
Merged
5 tasks
@st0012 st0012 self-assigned this Feb 10, 2022
@lewispb
Copy link
Contributor

lewispb commented Feb 13, 2022

Going to start looking at this now, unless you have already started something @st0012!

@lewispb lewispb mentioned this issue Feb 13, 2022
Merged
5.x automation moved this from To do to Done Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st0012 st0012

Labels
enhancement sentry-ruby tracing
Projects
5.x
Done
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Log Redis command arguments if send_default_pii = true lewispb/sentry-ruby
2 participants
@lewispb @st0012