Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Redis command arguments if send_default_pii = true #1726

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

lewispb
Copy link
Contributor

@lewispb lewispb commented Feb 13, 2022

Closes #1718

Description

When config.send_default_pii = true we will also log any Redis command arguments

@st0012 st0012 added this to In progress in 5.x via automation Feb 18, 2022
@st0012 st0012 added this to the 5.2.0 milestone Feb 18, 2022
@st0012
Copy link
Collaborator

st0012 commented Feb 18, 2022

@lewispb Thanks for the work! Again! The PR looks great but I need to do one or two patch releases before merging 5.2.0 features. So I need to let it park here for a while.

@lewispb
Copy link
Contributor Author

lewispb commented Feb 20, 2022

No worries at all @st0012! I just pushed a test case I missed for the span description.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #1726 (dc7e920) into master (623d046) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1726   +/-   ##
=======================================
  Coverage   98.40%   98.41%           
=======================================
  Files         141      141           
  Lines        8012     8056   +44     
=======================================
+ Hits         7884     7928   +44     
  Misses        128      128           
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/redis.rb 100.00% <100.00%> (ø)
...y-ruby/spec/sentry/breadcrumb/redis_logger_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/redis_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/hub.rb 100.00% <0.00%> (ø)
sentry-resque/lib/sentry/resque.rb 100.00% <0.00%> (ø)
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <0.00%> (ø)
sentry-ruby/spec/initialization_check_spec.rb 100.00% <0.00%> (ø)
...y-ruby/spec/sentry/rack/capture_exceptions_spec.rb 100.00% <0.00%> (ø)
sentry-ruby/spec/sentry_spec.rb 99.74% <0.00%> (+<0.01%) ⬆️
sentry-resque/spec/sentry/resque_spec.rb 97.84% <0.00%> (+0.03%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623d046...dc7e920. Read the comment docs.

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the follow up work 👍

@st0012 st0012 merged commit bad64df into getsentry:master Mar 4, 2022
5.x automation moved this from In progress to Done Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

Record redis command arguments in breadcrumbs and tracing spans.
3 participants