You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@hogelog thanks for reporting this, I've attached a PR for it.
and using config.async is actually not recommended. I've detailed the reasons in #1522 and please let me know your opinion on it 🙂
I'm developing rails app that uses config.async with Sidekiq, but I will disable this config and use background worker or send synchronously.
It is very clear that the config.async feature incurs extra costs for sentry-ruby maintenance (just like this bug). I agree with removing this feature.
@st0012 sorry for bringing this back to life, but i found that making this change in the config block for sentry would update the overall apps logger to WARN, which means we loose things like route logs.
is there anyway to tell sentry not to notify that it is sending the envelopes besides at the logger level specifically?
Issue Description
sentry-ruby 5.2.0 introduce envelope size check logic.
#1747
This logic check envelope size, and remove breadcrumbs if payload is too huge.
https://github.com/getsentry/sentry-ruby/blob/5.2.0/sentry-ruby/lib/sentry/transport.rb#L75-L78
But this breadcrumbs remove process does not work with
config.async
option.item.payload
has JSON-like string key whenconfig.async
is enabled.https://github.com/getsentry/sentry-ruby/blob/5.2.0/sentry-ruby/lib/sentry/client.rb#L166-L168
Reproduction Steps
docker run --rm -p 8080:80 ealen/echo-server
Expected Behavior
Removing breadcrumbs logic work fine when
config.async
is enabled or not.Actual Behavior
Removing breadcrumbs logic does not work when
config.async
is enabled.Ruby Version
2.7.4
SDK Version
5.2.0
Integration and Its Version
No response
Sentry Config
No response
The text was updated successfully, but these errors were encountered: