Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Span Operations #1903

Closed
AbhiPrasad opened this issue Sep 27, 2022 · 3 comments · Fixed by #1923
Closed

Align Span Operations #1903

AbhiPrasad opened this issue Sep 27, 2022 · 3 comments · Fixed by #1923

Comments

@AbhiPrasad
Copy link
Member

As per getsentry/develop#694, we should align our span operations.

SDK Old Operation New Operation Link PR
Ruby
delayed_job queue.task.delayed_job
transaction = Sentry.start_transaction(name: scope.transaction_name, op: "delayed_job")
rails.action_cable websocket.server
options = { name: transaction_name, op: "rails.action_cable".freeze }
active_job queue.task.active_job
Sentry.start_transaction(name: scope.transaction_name, op: "active_job")
rails.request http.server
process_action.action_controller view.process_action.action_controller
EVENT_NAMES = ["process_action.action_controller"].freeze
service_upload.active_storage file.service_upload.active_storage
service_download.active_storage file.service_download.active_storage
service_streaming_download.active_storage file.service_streaming_download.active_storage
service_download_chunk.active_storage file.service_download_chunk.active_storage
service_delete.active_storage file.service_delete.active_storage
service_delete_prefixed.active_storage file.service_delete_prefixed.active_storage
service_exist.active_storage file.service_exist.active_storage
service_url.active_storage file.service_url.active_storage
service_mirror.active_storage file.service_mirror.active_storage
service_update_metadata.active_storage file.service_update_metadata.active_storage
preview.active_storage file.preview.active_storage
analyze.active_storage file.analyze.active_storage
resque queue.resque
transaction = Sentry.start_transaction(name: scope.transaction_name, op: "resque")
db.redis.command db.redis
OP_NAME = "db.redis.command"
rack.request http.server
options = { name: scope.transaction_name, op: transaction_op }
sidekiq queue.sidekiq
options = { name: transaction_name, op: "sidekiq" }
@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@st0012
Copy link
Collaborator

st0012 commented Oct 23, 2022

What's the difference between queue.task.* and queue.*? I think resque, delayed_job, and sidekiq should all have the same op. I'd also argue that active_job should share the same op as well because it's just an abstraction layer for the above libraries.

@st0012 st0012 self-assigned this Oct 23, 2022
@st0012 st0012 added this to the 6.0.0 milestone Oct 23, 2022
@st0012 st0012 added this to To do in 5.x via automation Oct 23, 2022
@st0012 st0012 modified the milestones: 6.0.0, 5.6.0 Oct 23, 2022
@AbhiPrasad
Copy link
Member Author

queue.task.* and queue.* are both categorized as queue operations to the Sentry products - the difference is basically just semantic meaning.

I'd be all for refactoring this list if you have opinions @st0012 - especially to encourage consistency.

5.x automation moved this from To do to Done Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment