Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Span Operations for Audit #694

Merged
merged 7 commits into from Sep 28, 2022
Merged

Update Span Operations for Audit #694

merged 7 commits into from Sep 28, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Sep 27, 2022

https://www.notion.so/sentry/Set-up-an-audit-for-SDK-consistency-for-span-operations-to-enable-performance-issues-addf02a8fa234dda8acf48d4ff9b8efb?d=b852bdd1e9914d2ca74c1052296081f3#d04af01302604881999b1bd29c837b1f

This PR attempts to align our span operations based on an audit we've taken on in the past 2 weeks. The reason we are trying to align our span operations is because they are required to generate consistent performance issues: getsentry/sentry#37083

In addition, to this PR, we've collected a list of span operations we'll need to update across the different SDKs: #693 (comment)

@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
develop ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 3:51PM (UTC)

@AbhiPrasad AbhiPrasad changed the title Span Ops Audit Update Span Operations for Audit Sep 27, 2022
@AbhiPrasad AbhiPrasad mentioned this pull request Sep 27, 2022
6 tasks
@AbhiPrasad AbhiPrasad marked this pull request as ready for review September 27, 2022 12:22
@cleptric
Copy link
Member

@AbhiPrasad I talked to @stayallive, and we're happy with

laravel.handle -> middleware.handle
laravel.bootstrap -> app.bootstrap
laravel.autoload -> app.php.autoload
laravel.view -> view.render

for Laravel 👍

@gggritso
Copy link
Member

@AbhiPrasad out of curiosity, why is the convention category.framework.action and not category.action.framework (e.g., ui.react.update vs. ui.update.react)? I'm only asking because if we wanted to filter for all UI update ops (ui.react.update, ui.vue.update, etc.), it'd be easier to do op.startswith("ui.update") than having to do wildcard matches on ui.*.update. That's just an example, I'm only wondering why the convention is what it is!

@AbhiPrasad
Copy link
Member Author

@AbhiPrasad out of curiosity, why is the convention category.framework.action and not category.action.framework (e.g., ui.react.update vs. ui.update.react)? I'm only asking because if we wanted to filter for all UI update ops (ui.react.update, ui.vue.update, etc.), it'd be easier to do op.startswith("ui.update") than having to do wildcard matches on ui.*.update. That's just an example, I'm only wondering why the convention is what it is!

It's because the action for the ui.framework.X is dependent on the framework itself. For example, init is a lifecycle in Svelte, but not in Vue or React.

@gggritso
Copy link
Member

@AbhiPrasad that's what I figured, thanks!

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AbhiPrasad and @jan-auer

@AbhiPrasad
Copy link
Member Author

We're now merging this - we can continue to iterate on this as needed.

@AbhiPrasad AbhiPrasad merged commit 2f9c457 into master Sep 28, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-span-ops-align branch September 28, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants