Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the timing of loading ActiveJobExtensions #1464

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Correct the timing of loading ActiveJobExtensions #1464

merged 2 commits into from
Jun 4, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jun 3, 2021

Fixes #1249

@st0012 st0012 added this to the 4.5.1 milestone Jun 3, 2021
@st0012 st0012 self-assigned this Jun 3, 2021
@st0012 st0012 added this to In progress in 4.x via automation Jun 3, 2021
@st0012 st0012 merged commit a72ddc7 into master Jun 4, 2021
4.x automation moved this from In progress to Done Jun 4, 2021
@st0012 st0012 deleted the fix-#1249 branch June 4, 2021 07:51
@@ -12,13 +12,19 @@ class Railtie < ::Rails::Railtie
app.config.middleware.use(Sentry::Rails::RescuedExceptionInterceptor)
end

# because the extension works by registering the around_perform callcack, it should always be ran
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"callcack" => "callback"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

sentry + eager_load breaks ActiveJob rescue_from
2 participants