Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable release detection when SDK is not configured to send events #1471

Merged
merged 3 commits into from Jun 11, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jun 11, 2021

This PR fixes 2 issues:

This allows the SDK to log release detection messages with the logger
user provides.
This makes sure the users don't see release detection warnings when they
don't even plan to use it.

Closes #885
@st0012 st0012 added this to the 4.5.2 milestone Jun 11, 2021
@st0012 st0012 self-assigned this Jun 11, 2021
@st0012 st0012 added this to In progress in 4.x via automation Jun 11, 2021
@st0012 st0012 merged commit e73fd76 into master Jun 11, 2021
@st0012 st0012 deleted the fix-#885 branch June 11, 2021 10:31
4.x automation moved this from In progress to Done Jun 11, 2021
@st0012 st0012 modified the milestones: 4.5.2, 4.6.0 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant