Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up #1469 #1483

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Follow up #1469 #1483

merged 2 commits into from
Jun 25, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jun 25, 2021

This PR:

  1. Simplifies tests added in Set user to the current scope via sidekiq middleware #1469
  2. Adds a changelog entry.

@st0012 st0012 added this to the 4.6.0 milestone Jun 25, 2021
@st0012 st0012 self-assigned this Jun 25, 2021
@st0012 st0012 added this to In progress in 4.x via automation Jun 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #1483 (3129452) into master (79f0453) will increase coverage by 0.54%.
The diff coverage is 100.00%.

❗ Current head 3129452 differs from pull request most recent head 1b96dd6. Consider uploading reports for the commit 1b96dd6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
+ Coverage   98.21%   98.76%   +0.54%     
==========================================
  Files         218      123      -95     
  Lines       10471     6624    -3847     
==========================================
- Hits        10284     6542    -3742     
+ Misses        187       82     -105     
Impacted Files Coverage Δ
...c/sentry/sidekiq/sentry_context_middleware_spec.rb 100.00% <100.00%> (ø)
...iq/lib/sentry/sidekiq/sentry_context_middleware.rb 96.87% <0.00%> (-3.13%) ⬇️
sentry-raven/lib/raven/processor/http_headers.rb
sentry-raven/lib/raven/event.rb
...ntry-raven/spec/raven/processors/post_data_spec.rb
...y-raven/lib/raven/integrations/rails/active_job.rb
...en/lib/raven/integrations/sidekiq/error_handler.rb
sentry-raven/spec/raven/interface_spec.rb
sentry-raven/lib/raven/processor/sanitizedata.rb
sentry-raven/spec/raven/transports/http_spec.rb
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f0453...1b96dd6. Read the comment docs.

@st0012 st0012 merged commit d82b463 into master Jun 25, 2021
@st0012 st0012 deleted the follow-up-#1469 branch June 25, 2021 08:07
4.x automation moved this from In progress to Done Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants