Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force encode request body if it's a string #1484

Merged
merged 2 commits into from Jun 25, 2021
Merged

Force encode request body if it's a string #1484

merged 2 commits into from Jun 25, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jun 25, 2021

Fixes #1475 and #1303

@st0012 st0012 added this to the 4.6.0 milestone Jun 25, 2021
@st0012 st0012 self-assigned this Jun 25, 2021
@st0012 st0012 added this to In progress in 4.x via automation Jun 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #1484 (4aa09ba) into master (d82b463) will increase coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
+ Coverage   98.20%   98.76%   +0.55%     
==========================================
  Files         218      123      -95     
  Lines       10461     6627    -3834     
==========================================
- Hits        10273     6545    -3728     
+ Misses        188       82     -106     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/interfaces/request.rb 94.82% <100.00%> (+0.09%) ⬆️
...y/spec/sentry/interfaces/request_interface_spec.rb 99.14% <100.00%> (+0.03%) ⬆️
sentry-rails/lib/sentry/rails/active_job.rb 97.05% <0.00%> (-0.09%) ⬇️
sentry-rails/lib/sentry/rails/configuration.rb 100.00% <0.00%> (ø)
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb 100.00% <0.00%> (ø)
sentry-raven/spec/raven/raven_spec.rb
...raven/spec/raven/breadcrumbs/sentry_logger_spec.rb
sentry-raven/spec/raven/configuration_spec.rb
...ntry-raven/spec/raven/processors/post_data_spec.rb
sentry-raven/lib/raven/processor/cookies.rb
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82b463...4aa09ba. Read the comment docs.

@st0012 st0012 merged commit fac1db6 into master Jun 25, 2021
@st0012 st0012 deleted the fix-#1475 branch June 25, 2021 14:08
4.x automation moved this from In progress to Done Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Some event sending fail when POST request with non ASCII string
2 participants