Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSN#server shouldn't include path #1505

Merged
merged 2 commits into from
Jul 16, 2021
Merged

DSN#server shouldn't include path #1505

merged 2 commits into from
Jul 16, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jul 16, 2021

The path will be applied to DSN#envelope_endpoint anyway, so if #server also contains the path it'll be repeated.

The path will be applied to `DSN#envelope_endpoint` anyway, so if
`#server` also contains the path it'll be repeated.
@st0012 st0012 added this to the 4.7.0 milestone Jul 16, 2021
@st0012 st0012 self-assigned this Jul 16, 2021
@st0012 st0012 added this to In progress in 4.x via automation Jul 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #1505 (913e1d5) into master (6cc8966) will increase coverage by 0.56%.
The diff coverage is 100.00%.

❗ Current head 913e1d5 differs from pull request most recent head 8f8aca4. Consider uploading reports for the commit 8f8aca4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
+ Coverage   98.21%   98.78%   +0.56%     
==========================================
  Files         218      123      -95     
  Lines       10560     6722    -3838     
==========================================
- Hits        10372     6640    -3732     
+ Misses        188       82     -106     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/dsn.rb 100.00% <ø> (ø)
sentry-ruby/spec/sentry/dsn_spec.rb 100.00% <100.00%> (ø)
...-ruby/spec/sentry/transport/http_transport_spec.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/active_job.rb 97.05% <0.00%> (-0.09%) ⬇️
sentry-rails/lib/sentry/rails/configuration.rb 100.00% <0.00%> (ø)
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb 100.00% <0.00%> (ø)
sentry-raven/spec/raven/integrations/rack_spec.rb
sentry-raven/lib/raven/integrations/rails.rb
sentry-raven/lib/raven/utils/request_id.rb
sentry-raven/lib/raven/logger.rb
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc8966...8f8aca4. Read the comment docs.

@st0012 st0012 merged commit 3d82d7f into master Jul 16, 2021
4.x automation moved this from In progress to Done Jul 16, 2021
@st0012 st0012 deleted the fix-dsn-server branch July 16, 2021 08:12
@st0012 st0012 modified the milestones: 4.7.0, 4.6.2 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants