Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare delayed_job and sidekiq as integration gem's dependency #1506

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jul 16, 2021

No description provided.

@st0012 st0012 added this to the 4.7.0 milestone Jul 16, 2021
@st0012 st0012 self-assigned this Jul 16, 2021
@st0012 st0012 added this to In progress in 4.x via automation Jul 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #1506 (8b2ee54) into master (3d82d7f) will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   98.22%   98.78%   +0.56%     
==========================================
  Files         218      123      -95     
  Lines       10562     6725    -3837     
==========================================
- Hits        10374     6643    -3731     
+ Misses        188       82     -106     
Impacted Files Coverage Δ
sentry-raven/spec/raven/client_spec.rb
sentry-raven/lib/raven/core_ext/object/deep_dup.rb
...ntry-raven/spec/raven/integrations/sidekiq_spec.rb
...c/raven/integrations/sidekiq/error_handler_spec.rb
sentry-raven/lib/raven/processor/http_headers.rb
sentry-raven/lib/raven/interfaces/stack_trace.rb
sentry-raven/lib/raven/transports.rb
sentry-raven/lib/raven/interfaces/exception.rb
...ven/spec/raven/processors/removestacktrace_spec.rb
...ntry-raven/lib/raven/helpers/deprecation_helper.rb
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d82d7f...8b2ee54. Read the comment docs.

@st0012 st0012 merged commit bae8c5b into master Jul 16, 2021
@st0012 st0012 deleted the declare-delayed_job-and_sidekiq-as-dependency branch July 16, 2021 08:47
4.x automation moved this from In progress to Done Jul 16, 2021
@st0012 st0012 modified the milestones: 4.7.0, 4.6.2 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants