Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentry-rails' backtrace_cleanup_callback injection #1510

Merged
merged 3 commits into from
Jul 23, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jul 22, 2021

As spotted in #1076 (comment), sentry-rails always overrides the backtrace_cleanup_callback provided by the user. It should respect the existing value instead.

`sentry-rails` should check the presence `backtrace_cleanup_callback`
before assigning the default one.

The problem was spotted in #1076 (comment).
@st0012 st0012 added this to the 4.7.0 milestone Jul 22, 2021
@st0012 st0012 self-assigned this Jul 22, 2021
@st0012 st0012 added this to In progress in 4.x via automation Jul 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #1510 (60cdc6e) into master (bae8c5b) will increase coverage by 0.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
+ Coverage   98.22%   98.78%   +0.56%     
==========================================
  Files         218      123      -95     
  Lines       10562     6723    -3839     
==========================================
- Hits        10374     6641    -3733     
+ Misses        188       82     -106     
Impacted Files Coverage Δ
sentry-rails/lib/sentry/rails/railtie.rb 100.00% <100.00%> (ø)
...rails/spec/sentry/rails/controller_methods_spec.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails_spec.rb 100.00% <100.00%> (ø)
...ven/spec/raven/processors/removestacktrace_spec.rb
sentry-raven/lib/raven/breadcrumbs.rb
sentry-raven/spec/support/test_rails_app/app.rb
...y-raven/lib/raven/integrations/rails/active_job.rb
...raven/spec/raven/breadcrumbs/sentry_logger_spec.rb
sentry-raven/spec/raven/processors/cookies_spec.rb
sentry-raven/spec/raven/configuration_spec.rb
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae8c5b...60cdc6e. Read the comment docs.

@st0012 st0012 merged commit 157f958 into master Jul 23, 2021
@st0012 st0012 deleted the fix-sentry-rails-backtrace_cleanup_callback-injection branch July 23, 2021 04:21
4.x automation moved this from In progress to Done Jul 23, 2021
@st0012 st0012 modified the milestones: 4.7.0, 4.6.2 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants