-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Rake with a more elegant and reliable way #1517
Extend Rake with a more elegant and reliable way #1517
Conversation
As I mentioned in 4dc603b#r54080150, using
Can you tell me what caused the conflicts in your application? |
My other gem extends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix 👍
Extend Rake with a more elegant and reliable way
Closes #1520
Description
Per 4dc603b#r54079829
Overwriting methods with aliasing is is rather a bad practice and, since it may cause conflicts, circular dependencies and infinite loops.
Module#prepend
is more elegant and reliable.