Add monotonic_active_support_logger

[morissetcl]

Hi,

This is a proposal to support monotonic_time.

The regular subscriber use real_time and can jump forwards and backwards as the system time-of-day clock is changed. It can be confusing, especially when computing elapsed time.

Few years ago Two years ago Rails add a monotonic_subscriber for instrumentation, I think it will be great to add the ability to set it.

There is other places in the code where it could be propagated. (especially for tracing)
Just would like have your feelings about this option and if it could make sense for you.

BTW thanks for maintaining this gem it's really useful.

[codecov-commenter]

Codecov Report

Merging #1531 (1b2f2e6) into master (d101202) will increase coverage by 0.06%.
The diff coverage is 70.33%.

❗ Current head 1b2f2e6 differs from pull request most recent head c455276. Consider uploading reports for the commit c455276 to get more accurate results

@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
+ Coverage   98.21%   98.27%   +0.06%     
==========================================
  Files         218      126      -92     
  Lines       10624     6902    -3722     
==========================================
- Hits        10434     6783    -3651     
+ Misses        190      119      -71     

Impacted Files	Coverage Δ
sentry-rails/lib/sentry/rails/railtie.rb	96.72% <50.00%> (-3.28%)	⬇️
...rumbs/monotonic_active_support_breadcrumbs_spec.rb	52.94% <52.94%> (ø)
...ails/breadcrumb/monotonic_active_support_logger.rb	55.00% <55.00%> (ø)
...ils/breadcrumbs/active_support_breadcrumbs_spec.rb	100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/active_job.rb	97.05% <0.00%> (-0.09%)	⬇️
sentry-rails/lib/sentry/rails/configuration.rb	100.00% <0.00%> (ø)
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb	100.00% <0.00%> (ø)
...ven/spec/raven/utils/exception_cause_chain_spec.rb
sentry-raven/lib/raven/transports.rb
sentry-raven/spec/raven/processors/cookies_spec.rb
... and 95 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d101202...c455276. Read the comment docs.

[st0012]

@morissetcl thanks for the proposal. I didn't know about the monotonic feature until now!

but it looks like this feature is only added after Rails 6.1 (commit: rails/rails@93b652a). and having a global config only for a certain Rails version is confusing.

so I want to propose another idea: you can add a new breadcrumb logger: monotonic_active_support_logger for this support (which will print warnings + not being activated if the client's Rails version < 6.1). and the user can just use the config.breadcrumb_loggers option for this feature too.

[morissetcl]

@st0012 hmm excellent point. I'm going to make these changes.

What about #1531 (comment) ? Any thought ? If changes are necessary I propose to do them in a separate PR.

[st0012]

What about #1531 (comment) ? Any thought ? If changes are necessary I propose to do them in a separate PR.

Ah that's a good catch. Thank you 👍

[st0012]

@morissetcl oops, looks like #1535 caused an conflict on this. can you fix it?

[st0012]

Thank you 👍