Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check sentry-rails before injecting ActiveJob skippable adapters #1544

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 20, 2021

Fixes #1541

@st0012 st0012 added this to the 4.7.0 milestone Aug 20, 2021
@st0012 st0012 self-assigned this Aug 20, 2021
@st0012 st0012 added this to In progress in 4.x via automation Aug 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #1544 (8ac6ac5) into master (1fd9654) will increase coverage by 0.36%.
The diff coverage is 33.33%.

❗ Current head 8ac6ac5 differs from pull request most recent head f7adafc. Consider uploading reports for the commit f7adafc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1544      +/-   ##
==========================================
+ Coverage   97.89%   98.25%   +0.36%     
==========================================
  Files         222      127      -95     
  Lines       10833     6996    -3837     
==========================================
- Hits        10605     6874    -3731     
+ Misses        228      122     -106     
Impacted Files Coverage Δ
sentry-delayed_job/lib/sentry-delayed_job.rb 73.33% <0.00%> (ø)
sentry-resque/lib/sentry-resque.rb 73.33% <0.00%> (ø)
sentry-sidekiq/lib/sentry-sidekiq.rb 91.30% <100.00%> (ø)
sentry-raven/lib/raven/transports/http.rb
sentry-raven/spec/raven/instance_spec.rb
sentry-raven/spec/raven/linecache_spec.rb
sentry-raven/lib/raven/utils/deep_merge.rb
sentry-raven/spec/raven/client_state_spec.rb
...lib/raven/integrations/rails/controller_methods.rb
sentry-raven/spec/raven/utils/real_ip_spec.rb
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd9654...f7adafc. Read the comment docs.

@st0012 st0012 merged commit af9803a into master Aug 20, 2021
4.x automation moved this from In progress to Done Aug 20, 2021
@st0012 st0012 deleted the fix-#1541 branch August 20, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Implicit dependency of sentry-rails in sentry-resque
2 participants