Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root license #1555

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Add root license #1555

merged 2 commits into from
Sep 1, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 1, 2021

GitHub can't capture the repo's license from a link file. So I think we need to give it a copy of the actual license.

@st0012 st0012 added this to the 4.7.0 milestone Sep 1, 2021
@st0012 st0012 self-assigned this Sep 1, 2021
@st0012 st0012 added this to In progress in 4.x via automation Sep 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #1555 (268af63) into master (4e7eb21) will increase coverage by 0.37%.
The diff coverage is n/a.

❗ Current head 268af63 differs from pull request most recent head 19e7e4f. Consider uploading reports for the commit 19e7e4f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1555      +/-   ##
==========================================
+ Coverage   97.92%   98.29%   +0.37%     
==========================================
  Files         222      127      -95     
  Lines       10867     7030    -3837     
==========================================
- Hits        10641     6910    -3731     
+ Misses        226      120     -106     
Impacted Files Coverage Δ
sentry-raven/lib/raven/transports/stdout.rb
sentry-raven/lib/raven/base.rb
sentry-raven/lib/raven/cli.rb
sentry-raven/lib/raven/processor/cookies.rb
sentry-raven/lib/raven/integrations/sidekiq.rb
sentry-raven/spec/raven/raven_spec.rb
sentry-raven/lib/raven/utils/request_id.rb
...aven/integrations/rails/controller_methods_spec.rb
...y-raven/spec/raven/processors/http_headers_spec.rb
sentry-raven/lib/raven/interface.rb
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7eb21...19e7e4f. Read the comment docs.

Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @st0012 !

Most other SDKs call this file LICENSE (without extension), if it makes no difference otherwise I'd rename the file to match the other SDKs.

4.x automation moved this from In progress to Reviewer approved Sep 1, 2021
GitHub can't capture the license information from a symlink.
@st0012
Copy link
Collaborator Author

st0012 commented Sep 1, 2021

@rhcarvalho 👍 updated. merging now.

@st0012 st0012 merged commit 24bd8db into master Sep 1, 2021
4.x automation moved this from Reviewer approved to Done Sep 1, 2021
@st0012 st0012 deleted the add-root-license branch September 1, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants