Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-position RescuedExceptionInterceptor middleware #1564

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 3, 2021

Currently, exceptions raised by middlewares placed between RescuedExceptionInterceptor and DebugExceptions are rescued DebugExceptions without anyway to be reported to the CaptureExceptions middleware.

By placing RescuedExceptionInterceptor closer to DebugExceptions, it should avoid similar issues.

Closes #1563

Currently, exceptions raised by middlewares placed between
RescuedExceptionInterceptor and DebugExceptions are rescued
DebugExceptions without anyway to be reported to the CaptureExceptions
middleware.

By placing RescuedExceptionInterceptor closer to DebugExceptions, it
should avoid similar issues.
@st0012 st0012 added this to the 4.8.0 milestone Sep 3, 2021
@st0012 st0012 self-assigned this Sep 3, 2021
@st0012 st0012 added this to In progress in 4.x via automation Sep 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #1564 (19ba4e4) into master (d475015) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
+ Coverage   97.92%   98.29%   +0.37%     
==========================================
  Files         222      127      -95     
  Lines       10870     7034    -3836     
==========================================
- Hits        10644     6914    -3730     
+ Misses        226      120     -106     
Impacted Files Coverage Δ
sentry-rails/lib/sentry/rails/railtie.rb 96.72% <100.00%> (ø)
sentry-rails/spec/sentry/rails_spec.rb 100.00% <100.00%> (ø)
...ntry-raven/lib/raven/core_ext/object/duplicable.rb
sentry-raven/spec/raven/client_state_spec.rb
...lib/raven/integrations/rails/controller_methods.rb
sentry-raven/lib/raven/core_ext/object/deep_dup.rb
sentry-raven/lib/raven/interfaces/message.rb
...try-raven/lib/sentry_raven_without_integrations.rb
sentry-raven/spec/raven/integrations/rack_spec.rb
sentry-raven/lib/raven/transports.rb
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d475015...19ba4e4. Read the comment docs.

@st0012 st0012 merged commit 5e18f60 into master Sep 8, 2021
4.x automation moved this from In progress to Done Sep 8, 2021
@st0012 st0012 deleted the fix-#1563 branch September 8, 2021 03:18
@st0012 st0012 modified the milestones: 4.8.0, 4.7.2 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Missing or underreported errors for ActiveRecord::ConnectionTimeoutError
2 participants