Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default environment to 'development' #1565

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Change default environment to 'development' #1565

merged 2 commits into from
Sep 3, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 3, 2021

Most people use development instead of default as their default environment. This change should prevent other issues similar to #1559.

Closes #1559

@st0012 st0012 added this to the 4.8.0 milestone Sep 3, 2021
@st0012 st0012 self-assigned this Sep 3, 2021
@st0012 st0012 added this to In progress in 4.x via automation Sep 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #1565 (92c5a14) into master (d475015) will decrease coverage by 2.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
- Coverage   97.92%   95.79%   -2.13%     
==========================================
  Files         222      110     -112     
  Lines       10870     6093    -4777     
==========================================
- Hits        10644     5837    -4807     
- Misses        226      256      +30     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 97.96% <100.00%> (-0.07%) ⬇️
sentry-ruby/spec/sentry/configuration_spec.rb 98.42% <100.00%> (ø)
sentry-ruby/spec/sentry_spec.rb 99.72% <100.00%> (-0.01%) ⬇️
.../lib/sentry/rails/rescued_exception_interceptor.rb 28.57% <0.00%> (-71.43%) ⬇️
sentry-rails/lib/sentry/rails/railtie.rb 27.86% <0.00%> (-68.86%) ⬇️
sentry-rails/app/jobs/sentry/send_event_job.rb 18.75% <0.00%> (-68.75%) ⬇️
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb 34.61% <0.00%> (-61.54%) ⬇️
sentry-rails/lib/sentry/rails/tracing.rb 35.48% <0.00%> (-61.30%) ⬇️
...entry-rails/lib/sentry/rails/capture_exceptions.rb 36.00% <0.00%> (-60.00%) ⬇️
sentry-rails/lib/sentry/rails/backtrace_cleaner.rb 47.05% <0.00%> (-52.95%) ⬇️
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d475015...92c5a14. Read the comment docs.

@st0012 st0012 merged commit 161951a into master Sep 3, 2021
4.x automation moved this from In progress to Done Sep 3, 2021
@st0012 st0012 deleted the fix-#1559 branch September 3, 2021 14:16
@st0012 st0012 modified the milestones: 4.8.0, 4.7.2 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Exceptions from ActiveJob with Resque backend are not captured on Sentry
2 participants