Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing subscribers should be multi-event based #1587

Merged
merged 2 commits into from
Oct 2, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Oct 2, 2021

This will make future extension (like #1558) easier to implement.

@st0012 st0012 added this to the 4.8.0 milestone Oct 2, 2021
@st0012 st0012 self-assigned this Oct 2, 2021
@st0012 st0012 added this to In progress in 4.x via automation Oct 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Merging #1587 (5eb4686) into master (53deb6e) will decrease coverage by 0.02%.
The diff coverage is 71.42%.

❗ Current head 5eb4686 differs from pull request most recent head b0d2aa9. Consider uploading reports for the commit b0d2aa9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
- Coverage   98.47%   98.44%   -0.03%     
==========================================
  Files         127      127              
  Lines        7091     7095       +4     
==========================================
+ Hits         6983     6985       +2     
- Misses        108      110       +2     
Impacted Files Coverage Δ
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb 75.86% <53.84%> (-4.91%) ⬇️
sentry-rails/lib/sentry/rails/tracing.rb 97.36% <100.00%> (+0.07%) ⬆️
...ntry/rails/tracing/action_controller_subscriber.rb 89.47% <100.00%> (ø)
...lib/sentry/rails/tracing/action_view_subscriber.rb 100.00% <100.00%> (ø)
...b/sentry/rails/tracing/active_record_subscriber.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53deb6e...b0d2aa9. Read the comment docs.

@st0012 st0012 merged commit 4ffa3a2 into master Oct 2, 2021
@st0012 st0012 deleted the multi-event-tracing-subscriber branch October 2, 2021 06:45
4.x automation moved this from In progress to Done Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants