Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ActiveStorage spans in tracing events #1588

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Oct 2, 2021

This implements and closes #1558

@st0012 st0012 added this to the 4.8.0 milestone Oct 2, 2021
@st0012 st0012 self-assigned this Oct 2, 2021
@st0012 st0012 added this to In progress in 4.x via automation Oct 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Merging #1588 (1513def) into master (4ffa3a2) will decrease coverage by 0.03%.
The diff coverage is 96.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1588      +/-   ##
==========================================
- Coverage   98.44%   98.41%   -0.04%     
==========================================
  Files         127      129       +2     
  Lines        7095     7192      +97     
==========================================
+ Hits         6985     7078      +93     
- Misses        110      114       +4     
Impacted Files Coverage Δ
.../sentry/rails/tracing/active_storage_subscriber.rb 92.30% <92.30%> (ø)
sentry-rails/spec/support/test_rails_app/app.rb 97.65% <94.54%> (-2.35%) ⬇️
sentry-rails/lib/sentry/rails/configuration.rb 96.15% <100.00%> (+0.15%) ⬆️
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb 76.66% <100.00%> (+0.80%) ⬆️
...ntry-rails/spec/sentry/rails/configuration_spec.rb 100.00% <100.00%> (ø)
...ry/rails/tracing/active_storage_subscriber_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffa3a2...1513def. Read the comment docs.

@georgeclaghorn
Copy link

Looking good. 👍

Screenshot of Sentry trace showing service_upload.active_storage event

@st0012
Copy link
Collaborator Author

st0012 commented Oct 4, 2021

@georgeclaghorn thanks!

@st0012 st0012 merged commit 5c17674 into master Oct 4, 2021
4.x automation moved this from In progress to Done Oct 4, 2021
@st0012 st0012 deleted the implement-#1558 branch October 4, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Rails integration: trace Active Storage events
3 participants