Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable local variable capture TracePoint when SDK inits #1589

Merged
merged 3 commits into from
Oct 10, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Oct 7, 2021

In #1580, only exceptions happen in requests would have its local variables captured for testing purpose. And after more than a week of testing in a real-world Rails app, I didn't see any issue or regression. So this PR enabled the TracePoint globally to make it include exceptions outside of a request (e.g. background jobs).

@st0012 st0012 added this to the 4.8.0 milestone Oct 7, 2021
@st0012 st0012 self-assigned this Oct 7, 2021
@st0012 st0012 added this to In progress in 4.x via automation Oct 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #1589 (6c7f6cc) into master (dde4255) will decrease coverage by 0.00%.
The diff coverage is 85.00%.

❗ Current head 6c7f6cc differs from pull request most recent head a793b4a. Consider uploading reports for the commit a793b4a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         129      129              
  Lines        7218     7245      +27     
==========================================
+ Hits         7104     7130      +26     
- Misses        114      115       +1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 94.17% <40.00%> (-5.83%) ⬇️
sentry-rails/spec/sentry/rails/activejob_spec.rb 99.25% <100.00%> (+0.02%) ⬆️
sentry-ruby/lib/sentry/rack/capture_exceptions.rb 95.00% <100.00%> (+8.72%) ⬆️
...y-ruby/spec/sentry/rack/capture_exceptions_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry_spec.rb 99.74% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde4255...a793b4a. Read the comment docs.

@st0012 st0012 force-pushed the enable-locals-capture-globally branch from 16c2145 to 44f7814 Compare October 9, 2021 12:31
@st0012 st0012 force-pushed the enable-locals-capture-globally branch from 44f7814 to a793b4a Compare October 10, 2021 13:04
@st0012 st0012 merged commit 5a8041c into master Oct 10, 2021
@st0012 st0012 deleted the enable-locals-capture-globally branch October 10, 2021 13:19
4.x automation moved this from In progress to Done Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants