Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Sidekiq's transaction with its parent when possible #1590

Merged
merged 2 commits into from
Oct 9, 2021
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Oct 8, 2021

If there's a parent transaction on the client side, its sentry_trace should be passed and picked by the server side middleware, so the 2 transactions can connect.

connecting sidekiq trace

Closes #1586

If there's a parent transaction on the client side, its sentry_trace
should be passed and picked by the server side middleware, so the 2
transactions can connect.
@st0012 st0012 added this to the 4.8.0 milestone Oct 8, 2021
@st0012 st0012 self-assigned this Oct 8, 2021
@st0012 st0012 added this to In progress in 4.x via automation Oct 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #1590 (e588ef2) into master (5c17674) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1590   +/-   ##
=======================================
  Coverage   98.41%   98.42%           
=======================================
  Files         129      129           
  Lines        7192     7218   +26     
=======================================
+ Hits         7078     7104   +26     
  Misses        114      114           
Impacted Files Coverage Δ
...iq/lib/sentry/sidekiq/sentry_context_middleware.rb 97.29% <100.00%> (+0.52%) ⬆️
...c/sentry/sidekiq/sentry_context_middleware_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c17674...e588ef2. Read the comment docs.

@st0012 st0012 changed the title Connect Sidekiq's transaction with the previous one Connect Sidekiq's transaction with its parent when possible Oct 8, 2021
@st0012 st0012 merged commit dde4255 into master Oct 9, 2021
@st0012 st0012 deleted the fix-#1586 branch October 9, 2021 12:14
4.x automation moved this from In progress to Done Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Configuring Tracing for Sidekiq
2 participants