Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nil instead of false to disable callable settings #1594

Merged
merged 2 commits into from Oct 23, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Oct 23, 2021

Using false to disable settings doesn't match nowadays convention. So I'm changing the disabling value of before_send and async (both inherited from sentry-raven) from false to nil.
Since they are both disabled by default, most users shouldn't need to disable them manually anyway. So I think this change should have a minimum impact and can be shipped in a minor release.

@st0012 st0012 added this to the 4.8.0 milestone Oct 23, 2021
@st0012 st0012 self-assigned this Oct 23, 2021
@st0012 st0012 added this to In progress in 4.x via automation Oct 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2021

Codecov Report

Merging #1594 (c04d2af) into master (17836c4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
+ Coverage   98.43%   98.46%   +0.02%     
==========================================
  Files         129      129              
  Lines        7210     7218       +8     
==========================================
+ Hits         7097     7107      +10     
+ Misses        113      111       -2     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.99% <100.00%> (+1.00%) ⬆️
...ntry-ruby/spec/sentry/client/event_sending_spec.rb 99.53% <100.00%> (ø)
sentry-ruby/spec/sentry/configuration_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17836c4...c04d2af. Read the comment docs.

@st0012 st0012 added the bug fix label Oct 23, 2021
@st0012 st0012 merged commit a87b99d into master Oct 23, 2021
@st0012 st0012 deleted the unify-callable-setting-checking branch October 23, 2021 19:43
4.x automation moved this from In progress to Done Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants