Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] Support Sidekiq Tags in Sentry #1596

Merged
merged 1 commit into from Nov 5, 2021

Conversation

berniechiu
Copy link
Contributor

@berniechiu berniechiu commented Oct 24, 2021

closes #1488

Description

Add Sidekiq Tags to Sentry

Notes

Just Few things TBC

  • Since Sidekiq supports array of tags but Sentry supports different way of setup with key/value, not sure if given boolean value is a common practice here
  • default naming pattern I usesidekiq.#{name} here, the reason for prefixing with sidekiq is that tag naming sometimes can be too generic, might conflict with custom setup from users. But can also be other naming, welcome for any feedback

@berniechiu berniechiu changed the title [ENHANCE] Add Sidekiq Tags to Sentry [ENHANCE] Support Sidekiq Tags in Sentry Oct 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #1596 (7e6a287) into master (a87b99d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
+ Coverage   98.44%   98.46%   +0.01%     
==========================================
  Files         129      129              
  Lines        7218     7225       +7     
==========================================
+ Hits         7106     7114       +8     
+ Misses        112      111       -1     
Impacted Files Coverage Δ
...iq/lib/sentry/sidekiq/sentry_context_middleware.rb 97.50% <100.00%> (+0.20%) ⬆️
...c/sentry/sidekiq/sentry_context_middleware_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 100.00% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87b99d...7e6a287. Read the comment docs.

@st0012
Copy link
Collaborator

st0012 commented Oct 25, 2021

@berniechiu thanks for the PR 🎉 I'll take a look this week 🙂

@st0012 st0012 added this to the 4.8.0 milestone Oct 28, 2021
@st0012 st0012 added this to In progress in 4.x via automation Oct 28, 2021
Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berniechiu thanks for the great work 🎉

@st0012 st0012 merged commit 8cb170e into getsentry:master Nov 5, 2021
4.x automation moved this from In progress to Done Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Support sidekiq tags in sentry-sidekiq
3 participants