Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicated sampling on Transaction events #1601

Merged
merged 6 commits into from
Nov 4, 2021
Merged

Avoid duplicated sampling on Transaction events #1601

merged 6 commits into from
Nov 4, 2021

Commits on Oct 31, 2021

  1. Remove unnecessary sending check from Transport 

    Transport should only care about sending the event object to the right
destination with right format. It doesn't need to check if it's allowed
to send an event, which should already be done by
`Client#capture_event`.
    @st0012
    st0012 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    c2be79e View commit details
    Browse the repository at this point in the history

  2. Remove unused @configuration from Transport

    @st0012
    st0012 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    3dbda5c View commit details
    Browse the repository at this point in the history

  3. Remove sampling from general sending restriction logic

    @st0012
    st0012 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    adc7685 View commit details
    Browse the repository at this point in the history

  4. Check if the event is sampled in Client#capture_event

    @st0012
    st0012 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    3d55ef2 View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @st0012
    st0012 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    915a105 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Update sentry-ruby/lib/sentry/client.rb 

    Co-authored-by: Neel Shah <neelshah.sa@gmail.com>
    @st0012 @sl0thentr0py
    st0012 and sl0thentr0py committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    51248ce View commit details
    Browse the repository at this point in the history