-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing support to ActionCable
integration
#1640
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 98.45% 98.49% +0.03%
==========================================
Files 135 135
Lines 7505 7570 +65
==========================================
+ Hits 7389 7456 +67
+ Misses 116 114 -2
Continue to review full report at Codecov.
|
ActionCable
integrationActionCable
integration
ActionCable
integrationActionCable
integration
0e4b010
to
8363681
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
end | ||
end | ||
|
||
def start_transaction(env, transaction_name) | ||
sentry_trace = env["HTTP_SENTRY_TRACE"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible to define HTTP headers on WebSocket connections from Javascript to specify the trace ID. And the Sentry JS library only seems to append the trace id to XHR's. So I'm not sure how to actually use this feature?
contexts
instead ofextras
for the additional data.