Add tracing support to ActionCable integration
#1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 98.45% 98.49% +0.03%
==========================================
Files 135 135
Lines 7505 7570 +65
==========================================
+ Hits 7389 7456 +67
+ Misses 116 114 -2
Continue to review full report at Codecov.
|
st0012
changed the title
ActionCable integrationActionCable integration
st0012
changed the title
ActionCable integrationActionCable integration
st0012
force-pushed
the
improve-action-cable-integration
branch
from
0e4b010
to
8363681
Compare
lewispb
reviewed
Jan 27, 2022
| end | ||
| end | ||
|
|
||
| def start_transaction(env, transaction_name) | ||
| sentry_trace = env["HTTP_SENTRY_TRACE"] |
There was a problem hiding this comment.
It's not possible to define HTTP headers on WebSocket connections from Javascript to specify the trace ID. And the Sentry JS library only seems to append the trace id to XHR's. So I'm not sure how to actually use this feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextsinstead ofextrasfor the additional data.