Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Net::HTTP patch #1656

Merged
merged 4 commits into from
Dec 26, 2021
Merged

Refactor Net::HTTP patch #1656

merged 4 commits into from
Dec 26, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Dec 26, 2021

No description provided.

@st0012 st0012 added this to the 4.9.0 milestone Dec 26, 2021
@st0012 st0012 self-assigned this Dec 26, 2021
@st0012 st0012 added this to In progress in 4.x via automation Dec 26, 2021
@st0012 st0012 changed the title Refactor Net::HTTP Refactor Net::HTTP patch Dec 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2021

Codecov Report

Merging #1656 (3e58657) into master (1dc4bd8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1656      +/-   ##
==========================================
+ Coverage   98.47%   98.51%   +0.03%     
==========================================
  Files         135      136       +1     
  Lines        7663     7659       -4     
==========================================
- Hits         7546     7545       -1     
+ Misses        117      114       -3     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/net/http.rb 100.00% <100.00%> (+2.00%) ⬆️
sentry-ruby/spec/contexts/with_request_mock.rb 100.00% <100.00%> (ø)
...ry-ruby/spec/sentry/breadcrumb/http_logger_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/net/http_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/background_worker.rb 100.00% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc4bd8...3e58657. Read the comment docs.

@st0012 st0012 merged commit 5883c9d into master Dec 26, 2021
@st0012 st0012 deleted the improve-net-http branch December 26, 2021 17:47
4.x automation moved this from In progress to Done Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants