Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly passing Rack related configurations #1662

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jan 2, 2022

Since RequestInterface is directly initialized from Event, it's entirely possible to pass everything it needs with method calls.

This change will make RequestInterface's dependencies clearer and shouldn't break any user program (interfaces shouldn't be initialized manually).

@st0012 st0012 added this to the 4.9.0 milestone Jan 2, 2022
@st0012 st0012 self-assigned this Jan 2, 2022
@st0012 st0012 added this to In progress in 4.x via automation Jan 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2022

Codecov Report

Merging #1662 (10ab72e) into master (d583528) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1662   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         136      136           
  Lines        7655     7656    +1     
=======================================
+ Hits         7538     7539    +1     
  Misses        117      117           
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/event.rb 98.87% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/interfaces/request.rb 95.16% <100.00%> (ø)
...y/spec/sentry/interfaces/request_interface_spec.rb 99.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d583528...10ab72e. Read the comment docs.

@st0012 st0012 merged commit 7fb3092 into master Jan 4, 2022
@st0012 st0012 deleted the pass-rack-config-explicitly branch January 4, 2022 20:00
4.x automation moved this from In progress to Done Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants