Support serializing ActiveRecord job arguments in global id form

[st0012]

Thanks for @bjeanes's proposal and on the idea and implementation in #1643

Closes #1643

[codecov-commenter]

Codecov Report

Merging #1688 (1045a21) into master (d6b63bb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1688      +/-   ##
==========================================
+ Coverage   98.56%   98.59%   +0.03%     
==========================================
  Files         136      136              
  Lines        7782     7808      +26     
==========================================
+ Hits         7670     7698      +28     
+ Misses        112      110       -2     

Impacted Files	Coverage Δ
sentry-rails/lib/sentry/rails/active_job.rb	100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/activejob_spec.rb	99.37% <100.00%> (+0.08%)	⬆️
sentry-ruby/lib/sentry/background_worker.rb	100.00% <0.00%> (+5.40%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b63bb...1045a21. Read the comment docs.

[lewispb]

Presuming we have Active Support available here in sentry-rails, we could perhaps simplify the implementation with #deep_transform_values

[bjeanes]

Good point. I think this code is roughly based on my initial issue wherein I didn't want to assume ActiveSuport, but given this is would be in the -rails gem, seems fine to assume it's there.

[st0012]

@lewispb Yeah that makes sense. I'll update it 👍

[st0012]

Well I did simplify the implementation to:

      def sentry_serialize_arguments(argument)
        case argument
        when Hash
          argument.deep_transform_values { |v| sentry_serialize_arguments(v) }
        when Array, Enumerable
          argument.map { |v| sentry_serialize_arguments(v) }
        when ->(v) { v.respond_to?(:to_global_id) }
          argument.to_global_id.to_s
        else
          argument
        end
      rescue StandardError
        argument
      end

But it turns out deep_transform_values is added after Rails 6.0. And we're still supporting Rails 5.*, so....

I'll check if just transform_value will work.

[lewispb]

Ah ok 😅

[st0012]

@lewispb fyi transform_values also works 😄

[st0012]

@lewispb fyi transform_values also works 😄