Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction#finish should ignore the parent's sampling decision #1716

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Feb 10, 2022

Fixes #1712

@st0012 st0012 added this to the 5.1.0 milestone Feb 10, 2022
@st0012 st0012 self-assigned this Feb 10, 2022
@st0012 st0012 added this to In progress in 5.x via automation Feb 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #1716 (db5ecbe) into master (ee5eadc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1716      +/-   ##
==========================================
+ Coverage   98.41%   98.42%   +0.01%     
==========================================
  Files         140      140              
  Lines        7990     7994       +4     
==========================================
+ Hits         7863     7868       +5     
+ Misses        127      126       -1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/transaction.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transaction_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 100.00% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5eadc...db5ecbe. Read the comment docs.

@st0012 st0012 merged commit aeb38cf into master Feb 10, 2022
@st0012 st0012 deleted the fix-#1712 branch February 10, 2022 15:03
5.x automation moved this from In progress to Done Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

Logs are misleading when transaction is sampled due to parent being sampled
3 participants