Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip authorization header when send_default_pii is false #1717

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Feb 10, 2022

Fixes #1714

@st0012 st0012 added this to the 5.1.0 milestone Feb 10, 2022
@st0012 st0012 added this to In progress in 5.x via automation Feb 10, 2022
@st0012 st0012 self-assigned this Feb 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #1717 (bd9633c) into master (aeb38cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1717      +/-   ##
==========================================
+ Coverage   98.42%   98.43%   +0.01%     
==========================================
  Files         140      140              
  Lines        7994     8001       +7     
==========================================
+ Hits         7868     7876       +8     
+ Misses        126      125       -1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/interfaces/request.rb 95.31% <100.00%> (+0.07%) ⬆️
...y/spec/sentry/interfaces/request_interface_spec.rb 99.07% <100.00%> (+0.05%) ⬆️
sentry-ruby/lib/sentry/breadcrumb.rb 96.29% <0.00%> (-3.71%) ⬇️
sentry-ruby/lib/sentry/background_worker.rb 100.00% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb38cf...bd9633c. Read the comment docs.

@st0012 st0012 merged commit 8c31a6d into master Feb 10, 2022
@st0012 st0012 deleted the fix-#1714 branch February 10, 2022 15:39
5.x automation moved this from In progress to Done Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

Authorization header is not being filtered in events from inbound requests
3 participants